Detect isolated nodes in finalize_workflow and prompt remediation#358
Open
zhongkaifu wants to merge 1 commit into
Open
Detect isolated nodes in finalize_workflow and prompt remediation#358zhongkaifu wants to merge 1 commit into
zhongkaifu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
finalize_workfloware not leaving behind truly isolated nodes (zero indegree and zero outdegree) that likely indicate missing bindings.params,depends_on, or branch targets to form connections.Description
_find_isolated_nodes(workflow)which computes indegree/outdegree usinginfer_edges_from_bindingsand returns nodes with zero in/out degree._build_isolated_nodes_feedback_messageto generate human/LLM-readable guidance about isolated nodes and suggested remediation tools likeupdate_action_node,update_condition_node, andupdate_loop_node.finalize_workflowwill check for isolated nodes and instruct authors to fix them before finalizing.finalize_workflowto call the new detection, includeisolated_nodesin the returned payload, append isolation feedback tofeedback, and markshould_continuewhen isolation review is required.Testing
Codex Task